Review Request: Do not return collectionFolders() unless ready.

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105246/#review14729
-----------------------------------------------------------



src/MountPointManager.cpp
<http://git.reviewboard.kde.org/r/105246/#comment11633>

    Hmmm, IMO this can be a source of subtle bugs where calling this important method is dependent on when it is called. I fear that callers of ::collectionFolders() cache the result so that could have long-ranging consequences.
    
    I'd rather see a fix that touches the _caller_ to ensure that MountPointManager is ready.


- Matěj Laitl


On June 13, 2012, 8:44 p.m., Edward Hades Toroshchin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105246/
> -----------------------------------------------------------
> 
> (Updated June 13, 2012, 8:44 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> If a collectionFolders() method of MountPointManager is called before it
> has completed identifying mount points, it adds the default path like
> $HOME/Music.
> 
> 
> This addresses bug 286219.
>     https://bugs.kde.org/show_bug.cgi?id=286219
> 
> 
> Diffs
> -----
> 
>   src/MountPointManager.h 910f777 
>   src/MountPointManager.cpp d3238c0 
> 
> Diff: http://git.reviewboard.kde.org/r/105246/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Edward Hades Toroshchin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120614/946b12ca/attachment.html>