Review Request: MediaDeviceCache: remove polling, solid events should suffice

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105221/#review14622
-----------------------------------------------------------

Ship it!


Testing done: mounted an external HDD via Plasma's Device Notifier.  This made an item corresponding to it appear in the "Local Music" pane of Amarok.  Unmounting it by the same method made it go away again.

- Alex Merry


On June 11, 2012, 3:14 p.m., Matěj Laitl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105221/
> -----------------------------------------------------------
> 
> (Updated June 11, 2012, 3:14 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> MediaDeviceCache: remove polling, solid events should suffice
> 
> This fixes a bug where Amarok (very probably needlessly) polls solid
> for all devices every single second (!!!) just to detect whether some
> unmounted paths become mounted or vice versa. This should not be needed
> at all, solid should notify us about everything.
> 
> However, I am not sure, so this is definitely not a material for 2.6
> final but rather 2.7 if no problems show up.
> 
> BUG: 289462
> FIXED-IN: 2.7
> REVIEW: 105221
> 
> 
> This addresses bug 289462.
>     https://bugs.kde.org/show_bug.cgi?id=289462
> 
> 
> Diffs
> -----
> 
>   src/MediaDeviceCache.h a48d453213e684d10b0a38b5b8ac01ae39680b52 
>   src/MediaDeviceCache.cpp 15583b8d4eb14f842242deaab18bc2d7033b5991 
> 
> Diff: http://git.reviewboard.kde.org/r/105221/diff/
> 
> 
> Testing
> -------
> 
> little
> 
> 
> Thanks,
> 
> Matěj Laitl
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120611/d2a4e58a/attachment.html>