Review Request: GSoC report: Integrate Spotify into Amarok <TODO> (squashed commits, recent on top)

Zhengliang Feng odayfans at gmail.com
Sun Jun 10 07:09:31 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105201/
-----------------------------------------------------------

Review request for Amarok.


Description
-------

Add Spotify collection code

Currently implemented SpotifyCollection, SpotifyQueryMaker and
SpotifyMeta. The ScriptResolver is the class handles communcation with
standalone Spotify resolver, the code is mainly from original
ScriptResolver, but added more functions to handle messages separately.

The controller class is used to start a ScriptResolver in a separate
thread and handles queries.


Diffs
-----

  src/core-impl/collections/CMakeLists.txt c78b9202ece71b51189c4e47d85acfa4a74ef8d6 
  src/core-impl/collections/spotifycollection/CMakeLists.txt PRE-CREATION 
  src/core-impl/collections/spotifycollection/SpotifyCollection.h PRE-CREATION 
  src/core-impl/collections/spotifycollection/SpotifyMeta.h PRE-CREATION 
  src/core-impl/collections/spotifycollection/SpotifyMeta.cpp PRE-CREATION 
  src/core-impl/collections/spotifycollection/SpotifyQueryMaker.h PRE-CREATION 
  src/core-impl/collections/spotifycollection/SpotifyQueryMaker.cpp PRE-CREATION 
  src/core-impl/collections/spotifycollection/support/Controller.h PRE-CREATION 
  src/core-impl/collections/spotifycollection/support/Controller.cpp PRE-CREATION 
  src/core-impl/collections/spotifycollection/support/QMFunctionTypes.h PRE-CREATION 
  src/core-impl/collections/spotifycollection/support/Query.h PRE-CREATION 
  src/core-impl/collections/spotifycollection/support/ScriptResolver.h PRE-CREATION 
  src/core-impl/collections/spotifycollection/support/ScriptResolver.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/105201/diff/


Testing
-------

Communication between ScriptResolver and Spotify resolver( from Tomahawk resolver repo https://github.com/ofan/tomahawk-resolvers ).
Logging into Spotify using a username and password.


Thanks,

Zhengliang Feng

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120610/90098fda/attachment-0001.html>


More information about the Amarok-devel mailing list