Review Request: Unit test : ActionsCapability

[Bart Cerneels]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105144/#review14402
-----------------------------------------------------------


I have a few nitpicks that are more about our API, ActionsCapability in particular.

As a part of the unit test patches you should improve the documentation as well. Will help to understand (and get us to properly define) the use cases of the interface.


tests/core/capabilities/TestActionsCapability.cpp
<http://git.reviewboard.kde.org/r/105144/#comment11366>

    Does ActionsCapability actually claim that it has to return the same objects in the same order as creation?
    Perhaps you should test the order and QProprties of the returned actions instead.



tests/core/capabilities/TestActionsCapability.cpp
<http://git.reviewboard.kde.org/r/105144/#comment11365>

    To verify this you could have created the capability with an empty list. Does not influence the test in any way.


- Bart Cerneels


On June 3, 2012, 3:45 p.m., Jasneet Bhatti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105144/
> -----------------------------------------------------------
> 
> (Updated June 3, 2012, 3:45 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> This is a patch implementing unit testing of core/capabilities/ActionsCapability
> 
> 
> Diffs
> -----
> 
>   tests/core/capabilities/TestActionsCapability.cpp PRE-CREATION 
>   tests/core/CMakeLists.txt c66d3be 
>   tests/core/capabilities/CMakeLists.txt PRE-CREATION 
>   tests/core/capabilities/TestActionsCapability.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/105144/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jasneet Bhatti
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120604/b5b94a5c/attachment.html>