GSoC update: Integrate Spotify into Amarok

[Bart Cerneels]

On Sun, Jun 3, 2012 at 5:48 PM, Ryan Feng <odayfans at gmail.com> wrote:
> On Sun, Jun 03, 2012 at 10:21:39AM +0200, Bart Cerneels wrote:
>> Date: Sun, 3 Jun 2012 10:21:39 +0200
>> To: amarok-devel at kde.org
>> Cc: Ryan Feng <odayfans at gmail.com>
>> From: Bart Cerneels <bart.cerneels at gmail.com>
>> Subject: Re: GSoC update: Integrate Spotify into Amarok
>>
>> On Sun, Jun 3, 2012 at 10:12 AM, Bart Cerneels <bart.cerneels at gmail.com> wrote:
>> > On Sun, Jun 3, 2012 at 6:32 AM, Ryan Feng <odayfans at gmail.com> wrote:
>> >> Hi,
>> >>
>> >>    Last week I posted a scratch code of the Amarok side resolver, I'm
>> >>    still working on it, like Leo and Bart said, there's no need to
>> >>    change the standalone Spotify resolver, so I won't touch it for a
>> >>    time, and I added SpotifyCollection, SpotifyQuery(or should be
>> >>    replaced by QueryMaker later) and Spotify::Resolver as the
>> >>    main class to start a new thread and handle user login, logout, track
>> >>    searching and stream etc. Still need to dive into the code of
>> >>    Collections and Playlists and figure out what's the best way to sync
>> >>    playlists between Amarok and Spotify.
>> >>
>> >>    Next week, I will still be working on the basic Spotify integration.
>> >>    The code is still in the scratch repo, it will be put together with
>> >>    Amarok and tested soon, and a working Spotify service with basic
>> >>    features should be seen by the end of the next week.
>> >>
>> >> Thanks,
>> >> Ryan Feng
>> >
>> > The code is here:
>> > http://quickgit.kde.org/index.php?p=clones%2Famarok%2Fzhengliangfeng%2Famarok-spotify.git&a=commitdiff&h=fb246b607f99a85fdff476ae189c53ad8a5fc4aa
> I forgot to post the link, it's still in scratch repo[1], but it will be put
> in my clone of Amarok soon. And if I use reviewboard to submit code, do I
> still need to post report mail to the mailing list?
>
>> I see you made the base class a Service. A Service, which is
>> represented in Amarok's Internet "tab" is only to be used by sources
>> of content that don't fit in either the CollectionBrowser (currently
>> still called "Local Music") or playlists sections.  Services don't
>> need to comply with the specific UI conventions of Collections and
>> PlaylistProviders but have to provide their own. The last.fm service
>> is the best example. The names have sort of been unfortunately chosen
>> and we're talking internally about changing then for 2.7 to avoid
>> confusion.
>>
>> You need to base your work on the Collection and QueryMaker classes so
>> Spotify will show up in the CollectionBrowser. I currently see no use
>> case that needs a special UI for Spotfiy, hence no need for Service.
> The reason why I used Service is because I thought users might need to
> input their username and password, and adjust Spotify settings such as
> 'High quality streaming' in a config dialog, just like what LastFM does.

That should be done through the plugin config dialog.

>
> [1] http://quickgit.kde.org/index.php?p=scratch%2Fzhengliangfeng%2Fgsoc-scratch.git&a=summary