Review Request: SoK - Unit Test : core/meta/support/PrivateMetaRegistry

[Jasneet Bhatti]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105525/
-----------------------------------------------------------

(Updated July 20, 2012, 2:13 p.m.)


Review request for Amarok, Matěj Laitl and Sven Krohlas.


Changes
-------

Made the changes as listed in the review above.


Description
-------

Added unit test for core/meta/support/PrivateMetaRegistry.

Also, tidied up the code style in the class being tested.


Diffs (updated)
-----

  src/core/meta/support/PrivateMetaRegistry.h f5959ac 
  tests/core/meta/CMakeLists.txt 3ae78c9 
  tests/core/meta/support/CMakeLists.txt PRE-CREATION 
  tests/core/meta/support/TestPrivateMetaRegistry.h PRE-CREATION 
  tests/core/meta/support/TestPrivateMetaRegistry.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/105525/diff/


Testing
-------

Builds, links and runs fine.

Output of running test with -v2 flag:

********* Start testing of TestPrivateMetaRegistry *********
Config: Using QTest library 4.8.1, Qt 4.8.1
INFO   : TestPrivateMetaRegistry::initTestCase() entering
QSYSTEM: TestPrivateMetaRegistry::initTestCase() qttest(16692)/kdecore (K*TimeZone*): No time zone information obtained from ktimezoned 
PASS   : TestPrivateMetaRegistry::initTestCase()
INFO   : TestPrivateMetaRegistry::testInsertAlbum() entering
INFO   : TestPrivateMetaRegistry::testInsertAlbum(Track01.ogg) COMPARE()
   Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(91)]
INFO   : TestPrivateMetaRegistry::testInsertAlbum(Track02.ogg) COMPARE()
   Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(91)]
INFO   : TestPrivateMetaRegistry::testInsertAlbum(Platz 01.mp3) COMPARE()
   Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(91)]
INFO   : TestPrivateMetaRegistry::testInsertAlbum(Platz 02.mp3) COMPARE()
   Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(91)]
INFO   : TestPrivateMetaRegistry::testInsertAlbum(Platz 03.mp3) COMPARE()
   Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(91)]
PASS   : TestPrivateMetaRegistry::testInsertAlbum()
INFO   : TestPrivateMetaRegistry::testInsertArtist() entering
INFO   : TestPrivateMetaRegistry::testInsertArtist(Track01.ogg) COMPARE()
   Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(108)]
INFO   : TestPrivateMetaRegistry::testInsertArtist(Track02.ogg) COMPARE()
   Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(108)]
INFO   : TestPrivateMetaRegistry::testInsertArtist(Platz 01.mp3) COMPARE()
   Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(108)]
INFO   : TestPrivateMetaRegistry::testInsertArtist(Platz 02.mp3) COMPARE()
   Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(108)]
INFO   : TestPrivateMetaRegistry::testInsertArtist(Platz 03.mp3) COMPARE()
   Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(108)]
PASS   : TestPrivateMetaRegistry::testInsertArtist()
INFO   : TestPrivateMetaRegistry::testInsertComposer() entering
INFO   : TestPrivateMetaRegistry::testInsertComposer(Track01.ogg) COMPARE()
   Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(125)]
INFO   : TestPrivateMetaRegistry::testInsertComposer(Track02.ogg) COMPARE()
   Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(125)]
INFO   : TestPrivateMetaRegistry::testInsertComposer(Platz 01.mp3) COMPARE()
   Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(125)]
INFO   : TestPrivateMetaRegistry::testInsertComposer(Platz 02.mp3) COMPARE()
   Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(125)]
INFO   : TestPrivateMetaRegistry::testInsertComposer(Platz 03.mp3) COMPARE()
   Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(125)]
PASS   : TestPrivateMetaRegistry::testInsertComposer()
INFO   : TestPrivateMetaRegistry::testInsertGenre() entering
INFO   : TestPrivateMetaRegistry::testInsertGenre(Track01.ogg) COMPARE()
   Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(142)]
INFO   : TestPrivateMetaRegistry::testInsertGenre(Track02.ogg) COMPARE()
   Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(142)]
INFO   : TestPrivateMetaRegistry::testInsertGenre(Platz 01.mp3) COMPARE()
   Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(142)]
INFO   : TestPrivateMetaRegistry::testInsertGenre(Platz 02.mp3) COMPARE()
   Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(142)]
INFO   : TestPrivateMetaRegistry::testInsertGenre(Platz 03.mp3) COMPARE()
   Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(142)]
PASS   : TestPrivateMetaRegistry::testInsertGenre()
INFO   : TestPrivateMetaRegistry::testInsertYear() entering
INFO   : TestPrivateMetaRegistry::testInsertYear(Track01.ogg) COMPARE()
   Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(159)]
INFO   : TestPrivateMetaRegistry::testInsertYear(Track02.ogg) COMPARE()
   Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(159)]
INFO   : TestPrivateMetaRegistry::testInsertYear(Platz 01.mp3) COMPARE()
   Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(159)]
INFO   : TestPrivateMetaRegistry::testInsertYear(Platz 02.mp3) COMPARE()
   Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(159)]
INFO   : TestPrivateMetaRegistry::testInsertYear(Platz 03.mp3) COMPARE()
   Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(159)]
PASS   : TestPrivateMetaRegistry::testInsertYear()
INFO   : TestPrivateMetaRegistry::testNull() entering
INFO   : TestPrivateMetaRegistry::testNull() COMPARE()
   Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(165)]
INFO   : TestPrivateMetaRegistry::testNull() COMPARE()
   Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(166)]
INFO   : TestPrivateMetaRegistry::testNull() COMPARE()
   Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(167)]
INFO   : TestPrivateMetaRegistry::testNull() COMPARE()
   Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(168)]
INFO   : TestPrivateMetaRegistry::testNull() COMPARE()
   Loc: [/home/jasneet/amarok/tests/core/meta/support/TestPrivateMetaRegistry.cpp(169)]
PASS   : TestPrivateMetaRegistry::testNull()
INFO   : TestPrivateMetaRegistry::cleanupTestCase() entering
PASS   : TestPrivateMetaRegistry::cleanupTestCase()
Totals: 8 passed, 0 failed, 0 skipped
********* Finished testing of TestPrivateMetaRegistry *********


Thanks,

Jasneet Bhatti

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120720/93ce1d85/attachment.html>