Review Request: SoK - Unit Test : core/meta/support/MetaKeys( AlbumKey )

[Jasneet Bhatti]

> On July 13, 2012, 1:03 p.m., Matěj Laitl wrote:
> > tests/core/meta/support/TestMetaAlbumKey.cpp, line 33
> > <http://git.reviewboard.kde.org/r/105497/diff/1/?file=71972#file71972line33>
> >
> >     How big are the added files? They should be no more than a few kilobytes in order not to make Amarok source unnecessary big. You can even create tracks in test programatically, see TestSqlScanManager::createTrack()

The two added files are 4.1 KB each, which I think is acceptable.

Moreover, I think future tests will require a few tracks with different tags for trivial testing. It would save time and effort to use these instead of creating tracks as in TestSqlScanManager.
OR
The track/album/etc. generation code can be moved out of TestSqlScanManager and made into a helper class of its own.


- Jasneet


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105497/#review15794
-----------------------------------------------------------


On July 14, 2012, 6:03 a.m., Jasneet Bhatti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105497/
> -----------------------------------------------------------
> 
> (Updated July 14, 2012, 6:03 a.m.)
> 
> 
> Review request for Amarok, Matěj Laitl and Sven Krohlas.
> 
> 
> Description
> -------
> 
> Unit test for class AlbumKey of core/meta/support/MetaKeys
> 
> Created a couple of silent tracks( take negligible space ) for testing with the artist and album names comprehensively. Seemed like a smarter way than to create large mocks since no other functionality is to be tested for.
> 
> 
> Diffs
> -----
> 
>   src/core/meta/support/MetaKeys.h 1a2fc25 
>   tests/core/meta/CMakeLists.txt 3ae78c9 
>   tests/core/meta/support/CMakeLists.txt PRE-CREATION 
>   tests/core/meta/support/TestMetaAlbumKey.h PRE-CREATION 
>   tests/core/meta/support/TestMetaAlbumKey.cpp PRE-CREATION 
>   tests/data/audio/album2/Track01.ogg PRE-CREATION 
>   tests/data/audio/album2/Track02.ogg PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/105497/diff/
> 
> 
> Testing
> -------
> 
> Builds, links and runs fine.
> 
> Output of running test with -v2 flag:
> 
> ********* Start testing of TestMetaAlbumKey *********
> Config: Using QTest library 4.8.1, Qt 4.8.1
> INFO   : TestMetaAlbumKey::initTestCase() entering
> QSYSTEM: TestMetaAlbumKey::initTestCase() qttest(431)/kdecore (K*TimeZone*): No time zone information obtained from ktimezoned 
> PASS   : TestMetaAlbumKey::initTestCase()
> INFO   : TestMetaAlbumKey::testOperatorAssignment() entering
> INFO   : TestMetaAlbumKey::testOperatorAssignment() QVERIFY(!( albumKey1 == albumKey2 ))
>    Loc: [/home/jasneet/amarok/tests/core/meta/support/TestMetaAlbumKey.cpp(55)]
> INFO   : TestMetaAlbumKey::testOperatorAssignment() QVERIFY(albumKey1 == tempAlbumKey)
>    Loc: [/home/jasneet/amarok/tests/core/meta/support/TestMetaAlbumKey.cpp(59)]
> INFO   : TestMetaAlbumKey::testOperatorAssignment() QVERIFY(!( albumKey1 == albumKey2 ))
>    Loc: [/home/jasneet/amarok/tests/core/meta/support/TestMetaAlbumKey.cpp(64)]
> INFO   : TestMetaAlbumKey::testOperatorAssignment() QVERIFY(albumKey1 == tempAlbumKey)
>    Loc: [/home/jasneet/amarok/tests/core/meta/support/TestMetaAlbumKey.cpp(68)]
> PASS   : TestMetaAlbumKey::testOperatorAssignment()
> INFO   : TestMetaAlbumKey::testOperatorLessThan() entering
> INFO   : TestMetaAlbumKey::testOperatorLessThan() QVERIFY(albumKey1 < albumKey2)
>    Loc: [/home/jasneet/amarok/tests/core/meta/support/TestMetaAlbumKey.cpp(79)]
> INFO   : TestMetaAlbumKey::testOperatorLessThan() QVERIFY(!( albumKey1 < albumKey1 ))
>    Loc: [/home/jasneet/amarok/tests/core/meta/support/TestMetaAlbumKey.cpp(82)]
> INFO   : TestMetaAlbumKey::testOperatorLessThan() QVERIFY(albumKey2 < albumKey3)
>    Loc: [/home/jasneet/amarok/tests/core/meta/support/TestMetaAlbumKey.cpp(85)]
> INFO   : TestMetaAlbumKey::testOperatorLessThan() QVERIFY(albumKey1 < albumKey3)
>    Loc: [/home/jasneet/amarok/tests/core/meta/support/TestMetaAlbumKey.cpp(88)]
> INFO   : TestMetaAlbumKey::testOperatorLessThan() QVERIFY(albumKey4 < albumKey5)
>    Loc: [/home/jasneet/amarok/tests/core/meta/support/TestMetaAlbumKey.cpp(95)]
> INFO   : TestMetaAlbumKey::testOperatorLessThan() QVERIFY(!( albumKey4 < albumKey4 ))
>    Loc: [/home/jasneet/amarok/tests/core/meta/support/TestMetaAlbumKey.cpp(98)]
> INFO   : TestMetaAlbumKey::testOperatorLessThan() QVERIFY(albumKey5 < albumKey6)
>    Loc: [/home/jasneet/amarok/tests/core/meta/support/TestMetaAlbumKey.cpp(101)]
> INFO   : TestMetaAlbumKey::testOperatorLessThan() QVERIFY(albumKey4 < albumKey6)
>    Loc: [/home/jasneet/amarok/tests/core/meta/support/TestMetaAlbumKey.cpp(104)]
> PASS   : TestMetaAlbumKey::testOperatorLessThan()
> INFO   : TestMetaAlbumKey::cleanupTestCase() entering
> PASS   : TestMetaAlbumKey::cleanupTestCase()
> Totals: 4 passed, 0 failed, 0 skipped
> ********* Finished testing of TestMetaAlbumKey *********
> 
> 
> Thanks,
> 
> Jasneet Bhatti
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120714/1832c1e0/attachment.html>