Review Request: SoK - Unit Test : core/collections/support/TrackForUrlWorker
Matěj Laitl
matej at laitl.cz
Wed Jul 11 19:33:54 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105389/#review15691
-----------------------------------------------------------
> In order to ease life of reviewers, could you please paste output of `path/to/build/tests/<currenttestexecutable> -v2` into the Testing done field to testcase review requests?
:-)
- Matěj Laitl
On July 11, 2012, 7:31 p.m., Jasneet Bhatti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105389/
> -----------------------------------------------------------
>
> (Updated July 11, 2012, 7:31 p.m.)
>
>
> Review request for Amarok, Matěj Laitl and Sven Krohlas.
>
>
> Description
> -------
>
> Added unit test for core/collections/support/TrackForUrlWorker
>
> Just the one slot completeJob() to test.
> Tested for both KUrl and QString types of urls.
>
>
> Diffs
> -----
>
> tests/core/collections/CMakeLists.txt b01b655
> tests/core/collections/support/CMakeLists.txt PRE-CREATION
> tests/core/collections/support/TestTrackForUrlWorker.h PRE-CREATION
> tests/core/collections/support/TestTrackForUrlWorker.cpp PRE-CREATION
> tests/mocks/MockTrackForUrlWorker.h PRE-CREATION
> tests/mocks/MockTrackForUrlWorker.cpp PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/105389/diff/
>
>
> Testing
> -------
>
> Builds and runs fine.
>
>
> Thanks,
>
> Jasneet Bhatti
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120711/d3d26571/attachment.html>
More information about the Amarok-devel
mailing list