Review Request: SoK - Unit Test : core/collections/support/TrackForUrlWorker

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105389/#review15679
-----------------------------------------------------------

Ship it!


Nearly perfect now, ship it with fixed typos. In order to ease life of reviewers, could you please paste output of `path/to/build/tests/<currenttestexecutable> -v2` into the Testing done field to testcase review requests?


tests/core/collections/support/TestTrackForUrlWorker.cpp
<http://git.reviewboard.kde.org/r/105389/#comment12199>

    typo: text instead of test



tests/core/collections/support/TestTrackForUrlWorker.cpp
<http://git.reviewboard.kde.org/r/105389/#comment12200>

    text/test typo


- Matěj Laitl


On July 6, 2012, 5:38 p.m., Jasneet Bhatti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105389/
> -----------------------------------------------------------
> 
> (Updated July 6, 2012, 5:38 p.m.)
> 
> 
> Review request for Amarok, Matěj Laitl and Sven Krohlas.
> 
> 
> Description
> -------
> 
> Added unit test for core/collections/support/TrackForUrlWorker
> 
> Just the one slot completeJob() to test.
> Tested for both KUrl and QString types of urls.
> 
> 
> Diffs
> -----
> 
>   tests/core/collections/CMakeLists.txt b01b655 
>   tests/core/collections/support/CMakeLists.txt PRE-CREATION 
>   tests/core/collections/support/TestTrackForUrlWorker.h PRE-CREATION 
>   tests/core/collections/support/TestTrackForUrlWorker.cpp PRE-CREATION 
>   tests/mocks/MockTrackForUrlWorker.h PRE-CREATION 
>   tests/mocks/MockTrackForUrlWorker.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/105389/diff/
> 
> 
> Testing
> -------
> 
> Builds and runs fine.
> 
> 
> Thanks,
> 
> Jasneet Bhatti
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120711/8f44fa08/attachment-0001.html>