Review Request: SoK - Unit Test : core/meta/support/MetaKeys( TrackKey )

Jasneet Bhatti jazneetbhatti at gmail.com
Mon Jul 9 20:23:50 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105454/
-----------------------------------------------------------

(Updated July 9, 2012, 8:23 p.m.)


Review request for Amarok, Matěj Laitl and Sven Krohlas.


Changes
-------

Moved dataPath() from private slots to private, which is a more appropriate place for it.


Description
-------

Added a unit test for class TrackKey of core/meta/support/MetaKeys


Diffs (updated)
-----

  tests/core/meta/CMakeLists.txt 3ae78c9 
  tests/core/meta/support/CMakeLists.txt PRE-CREATION 
  tests/core/meta/support/TestMetaTrackKey.h PRE-CREATION 
  tests/core/meta/support/TestMetaTrackKey.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/105454/diff/


Testing
-------

Builds, and runs fine


Thanks,

Jasneet Bhatti

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120709/12594e9f/attachment.html>


More information about the Amarok-devel mailing list