Review Request: SoK - Unit Test : core/meta/support/MetaKeys( AlbumKey )

[Jasneet Bhatti]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105497/
-----------------------------------------------------------

Review request for Amarok, Matěj Laitl and Sven Krohlas.


Description
-------

Unit test for class AlbumKey of core/meta/support/MetaKeys

Created a couple of silent tracks( take negligible space ) for testing with the artist and album names comprehensively. Seemed like a smarter way than to create large mocks since no other functionality is to be tested for.


Diffs
-----

  tests/core/meta/CMakeLists.txt 3ae78c9 
  tests/core/meta/support/CMakeLists.txt PRE-CREATION 
  tests/core/meta/support/TestMetaAlbumKey.h PRE-CREATION 
  tests/core/meta/support/TestMetaAlbumKey.cpp PRE-CREATION 
  tests/data/audio/album PRE-CREATION 
  tests/data/audio/album PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/105497/diff/


Testing
-------

Builds, links and runs fine.


Thanks,

Jasneet Bhatti

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120709/30766d80/attachment.html>