Review Request: SoK - Unit Test : core/collections/support/TrackForUrlWorker

[Jasneet Bhatti]

> On July 5, 2012, 9:29 p.m., Matěj Laitl wrote:
> > tests/core/collections/support/TestTrackForUrlWorker.h, line 29
> > <http://git.reviewboard.kde.org/r/105389/diff/2/?file=71361#file71361line29>
> >
> >     Why these are public? Data members should be normally private.

Done away with these


> On July 5, 2012, 9:29 p.m., Matěj Laitl wrote:
> > tests/core/collections/support/TestTrackForUrlWorker.cpp, line 94
> > <http://git.reviewboard.kde.org/r/105389/diff/2/?file=71362#file71362line94>
> >
> >     testCompleteJobKUrl_data() and testCompleteJobQString_data() can share code, too, I suggest non-slot private testCompleteJobInternal_data()

Apparently, having a standalone textCompleteJobInternal_data() doesn't suffice as textCompleteJobInternal() isn't a test function.

So, testCompleteJobKUrl_data() and testCompleteJobQString_data() both call textCompleteJobInternal_data() to add test data.


- Jasneet


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105389/#review15417
-----------------------------------------------------------


On July 6, 2012, 8:54 a.m., Jasneet Bhatti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105389/
> -----------------------------------------------------------
> 
> (Updated July 6, 2012, 8:54 a.m.)
> 
> 
> Review request for Amarok, Matěj Laitl and Sven Krohlas.
> 
> 
> Description
> -------
> 
> Added unit test for core/collections/support/TrackForUrlWorker
> 
> Just the one slot completeJob() to test.
> Tested for both KUrl and QString types of urls.
> 
> 
> Diffs
> -----
> 
>   tests/core/collections/CMakeLists.txt b01b655 
>   tests/core/collections/support/CMakeLists.txt PRE-CREATION 
>   tests/core/collections/support/TestTrackForUrlWorker.h PRE-CREATION 
>   tests/core/collections/support/TestTrackForUrlWorker.cpp PRE-CREATION 
>   tests/mocks/MockTrackForUrlWorker.h PRE-CREATION 
>   tests/mocks/MockTrackForUrlWorker.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/105389/diff/
> 
> 
> Testing
> -------
> 
> Builds and runs fine.
> 
> 
> Thanks,
> 
> Jasneet Bhatti
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120706/8b55ccd7/attachment.html>