Review Request: SoK - Unit Test : core/collections/support/TrackForUrlWorker

[Jasneet Bhatti]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105389/
-----------------------------------------------------------

(Updated July 6, 2012, 8:54 a.m.)


Review request for Amarok, Matěj Laitl and Sven Krohlas.


Changes
-------

Now only one mock class exists.
Contrived helper methods done away with and _real usage_ implementation for testing done.
Also, test data now comes from the existing tracks available for tests in the tests/data folder instead of mock tracks.


Description
-------

Added unit test for core/collections/support/TrackForUrlWorker

Just the one slot completeJob() to test.
Tested for both KUrl and QString types of urls.


Diffs (updated)
-----

  tests/core/collections/CMakeLists.txt b01b655 
  tests/core/collections/support/CMakeLists.txt PRE-CREATION 
  tests/core/collections/support/TestTrackForUrlWorker.h PRE-CREATION 
  tests/core/collections/support/TestTrackForUrlWorker.cpp PRE-CREATION 
  tests/mocks/MockTrackForUrlWorker.h PRE-CREATION 
  tests/mocks/MockTrackForUrlWorker.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/105389/diff/


Testing
-------

Builds and runs fine.


Thanks,

Jasneet Bhatti

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120706/c936e753/attachment.html>