Review Request: SoK - Unit Test : core/collections/support/TrackForUrlWorker

[Jasneet Bhatti]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105389/
-----------------------------------------------------------

(Updated July 5, 2012, 12:07 a.m.)


Review request for Amarok, Matěj Laitl and Sven Krohlas.


Changes
-------

Made changes according to the review.

Apart from them, simplified the TrackForUrlWorkerMock class and then subclassed it in this test to include additional methods that are not necessarily required in other tests that might need to reuse TrackForUrlWorkerMock.


Description
-------

Added unit test for core/collections/support/TrackForUrlWorker

Just the one slot completeJob() to test.
Tested for both KUrl and QString types of urls.


Diffs (updated)
-----

  tests/core/collections/CMakeLists.txt b01b655 
  tests/core/collections/support/CMakeLists.txt PRE-CREATION 
  tests/core/collections/support/TestTrackForUrlWorker.h PRE-CREATION 
  tests/core/collections/support/TestTrackForUrlWorker.cpp PRE-CREATION 
  tests/mocks/MockTrackForUrlWorker.h PRE-CREATION 
  tests/mocks/MockTrackForUrlWorker.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/105389/diff/


Testing
-------

Builds and runs fine.


Thanks,

Jasneet Bhatti

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120705/3062985a/attachment.html>