Review Request: Do not use i18n() in global C-like variables

Albert Astals Cid tsdgeos at terra.es
Mon Jul 2 09:01:49 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105408/
-----------------------------------------------------------

Review request for Amarok.


Description
-------

If you use i18n() in stuff that gets called before the main KComponentData is created bad stuff happens [1] (and you were getting a warning about it for ages). This fixes it by using I18N_NOOP and then using i18n over it.


Diffs
-----

  shared/FileType.cpp 3ec66de 

Diff: http://git.reviewboard.kde.org/r/105408/diff/


Testing
-------

Stuff properly shows as translated now


Thanks,

Albert Astals Cid

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120702/fd3963e3/attachment.html>


More information about the Amarok-devel mailing list