Review Request: Some changes to make Amarok appearance more pretty

[Lucas Gomes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103603/
-----------------------------------------------------------

(Updated Jan. 27, 2012, 1:11 a.m.)


Review request for Amarok and Bart Cerneels.


Changes
-------

Fixed some problems with plural localization. 
Podcast's cover are now aligned and bigger. 
The star, that appears when a podcast has a new episode, is aligned on the bottonm left corner of the podcast cover. 
Removed the track count info from Podcastbrowser due to other developers preference.


Description
-------

This is my attempt to make QTreeView subclasses items, used in Amarok, more pretty by displaying some extra information. Notice that these extra information are usually the quantity of tracks in a album, the quantity of episodes in a podcast and the quantity of episodes marked as new in a podcast.

So, please help me to improve this feature even more by answering some questions:

1) Should I show the quantity of tracks on playlists listed in PlaylistBrowser too?
2) Is there any extra information that you think it's relevant to be showed somewhere (In QTreeViews)?

Link for my personal repository (Look for ui-improve branch):
http://quickgit.kde.org/index.php?p=clones%2Famarok%2Fgomes%2Fmaskmaster-amarok.git&a=summary


Diffs (updated)
-----

  src/browsers/playlistbrowser/PodcastNormalTreeItemDelegate.cpp PRE-CREATION 
  src/browsers/playlistbrowser/PodcastMergedTreeItemDelegate.cpp PRE-CREATION 
  src/browsers/playlistbrowser/PodcastModel.cpp 18334f6 
  src/browsers/collectionbrowser/CollectionNormalTreeItemDelegate.cpp PRE-CREATION 
  src/browsers/collectionbrowser/CollectionMergedTreeItemDelegate.cpp PRE-CREATION 
  src/browsers/CollectionTreeItem.h 3438adc 
  src/browsers/CollectionTreeItemModelBase.cpp e7f8e62 

Diff: http://git.reviewboard.kde.org/r/103603/diff/diff


Testing
-------

This patch should build. Everything is working as expected and there aren't any known issues.


Screenshots (updated)
-----------

CollectionBrowser
  http://git.reviewboard.kde.org/r/103603/s/420/
PodcastBrowser
  http://git.reviewboard.kde.org/r/103603/s/421/


Thanks,

Lucas Gomes

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120127/bae4499f/attachment.html>