Review Request: Bump the taglib dependency to 1.7

Daniel Faust hessijames at gmail.com
Thu Jan 26 14:24:51 UTC 2012


Hi,

actually taglib 1.7 is not needed, I just forgot to wrap the #include around 
the #ifdef ...

So I could either fix that and we can go back to taglib 1.6 or I'll remove all 
the #ifdef ... that are already used.

greetings Daniel


Commit Hook am Mittwoch, 25. Januar 2012
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103781/#review10071
> -----------------------------------------------------------
> 
> 
> This review has been submitted with commit 
72d9686e26980f7ef7436975a4239c343318fce1 by Christophe Giboudeaux to branch 
master.
> 
> - Commit Hook
> 
> 
> On Jan. 24, 2012, 11:39 a.m., Christophe Giboudeaux wrote:
> > 
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://git.reviewboard.kde.org/r/103781/
> > -----------------------------------------------------------
> > 
> > (Updated Jan. 24, 2012, 11:39 a.m.)
> > 
> > 
> > Review request for Amarok.
> > 
> > 
> > Description
> > -------
> > 
> > A build error was detected by our unstable package in Opensuse: 
https://build.opensuse.org/package/show?package=amarok&project=KDE%3AUnstable%3APlayground
> > 
> > A closer look points to commit 717342ed which includes 
taglib/flacpicture.h. This header doesn't exist in taglib 1.6.x
> > 
> > 
> > Diffs
> > -----
> > 
> >   CMakeLists.txt 2247390 
> > 
> > Diff: http://git.reviewboard.kde.org/r/103781/diff/diff
> > 
> > 
> > Testing
> > -------
> > 
> > 
> > Thanks,
> > 
> > Christophe Giboudeaux
> > 
> >
> 


More information about the Amarok-devel mailing list