Review Request: Avoid the crash @ QtGroupingProxy::addSourceRow

[Ralf Engels]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103741/#review9977
-----------------------------------------------------------


I agree.
This patch looks wrong.
beginInsertRows(.., 0, 0); should be valid.
See http://doc.trolltech.com/4.6/qabstractitemmodel.html#beginInsertRows


- Ralf Engels


On Jan. 19, 2012, 9:23 p.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103741/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2012, 9:23 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Avoid trying to add no rows (if i==0).
> 
> 
> This addresses bug 285541.
>     https://bugs.kde.org/show_bug.cgi?id=285541
> 
> 
> Diffs
> -----
> 
>   src/browsers/playlistbrowser/PlaylistBrowserModel.cpp e507547 
> 
> Diff: http://git.reviewboard.kde.org/r/103741/diff/diff
> 
> 
> Testing
> -------
> 
> Until this little change, I was reproducing the bug.
> 
> 
> Thanks,
> 
> Jaime Torres Amate
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120121/1d2a4a34/attachment.html>