Review Request: Possibility to give an UMS-Collaction a descriptive name

[Bart Cerneels]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103736/#review9969
-----------------------------------------------------------

Ship it!


Since the prettyName automatically falls back to the device name it gets from solid it's already configured automatically. As such it's a completely non invasive option in that dialog. It might be a good idea to prevent accidental changes by disabling the editability of the textEntry field, but that is nitpicking and can be done later in a few minutes.



- Bart Cerneels


On Jan. 20, 2012, 11:41 a.m., Volker Christian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103736/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2012, 11:41 a.m.)
> 
> 
> Review request for Amarok and Bart Cerneels.
> 
> 
> Description
> -------
> 
> I sometimes missed the possibility to give an UMS-Collection a descriptive name. This patch adds this feature to the USM-Collection.
> 
> 
> Diffs
> -----
> 
>   src/core-impl/collections/umscollection/UmsCollection.h 7c86fab 
>   src/core-impl/collections/umscollection/UmsCollection.cpp aaa9a6d 
>   src/core-impl/collections/umscollection/UmsConfiguration.ui d9a6365 
> 
> Diff: http://git.reviewboard.kde.org/r/103736/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> UMS-Config Dialog
>   http://git.reviewboard.kde.org/r/103736/s/417/
> UMS-Collection
>   http://git.reviewboard.kde.org/r/103736/s/418/
> 
> 
> Thanks,
> 
> Volker Christian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120120/0f17c460/attachment.html>