Review Request: Possibility to give an UMS-Collaction a descriptive name

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103736/#review9961
-----------------------------------------------------------


This looks good (apart from some whitespace errors), let's see what Bart says. Ability to change name is however somehow redundant, because AFACS Amarok uses filesystem label of the partition which should be editable by users. (Utilities line gnome-disk-utility allow you to do so)


src/core-impl/collections/umscollection/UmsCollection.h
<http://git.reviewboard.kde.org/r/103736/#comment8224>

    You added whitespace here.



src/core-impl/collections/umscollection/UmsCollection.cpp
<http://git.reviewboard.kde.org/r/103736/#comment8225>

    whitespace error.



src/core-impl/collections/umscollection/UmsCollection.cpp
<http://git.reviewboard.kde.org/r/103736/#comment8226>

    whitespace


- Matěj Laitl


On Jan. 20, 2012, 10:43 a.m., Volker Christian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103736/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2012, 10:43 a.m.)
> 
> 
> Review request for Amarok and Bart Cerneels.
> 
> 
> Description
> -------
> 
> I sometimes missed the possibility to give an UMS-Collection a descriptive name. This patch adds this feature to the USM-Collection.
> 
> 
> Diffs
> -----
> 
>   src/core-impl/collections/umscollection/UmsConfiguration.ui d9a6365 
>   src/core-impl/collections/umscollection/UmsCollection.h 7c86fab 
>   src/core-impl/collections/umscollection/UmsCollection.cpp aaa9a6d 
> 
> Diff: http://git.reviewboard.kde.org/r/103736/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> UMS-Config Dialog
>   http://git.reviewboard.kde.org/r/103736/s/417/
> UMS-Collection
>   http://git.reviewboard.kde.org/r/103736/s/418/
> 
> 
> Thanks,
> 
> Volker Christian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120120/3f393e1c/attachment.html>