Review Request: Visualization with projectM

[Ralf Engels]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102277/#review9879
-----------------------------------------------------------


Sorry for the late reply, first bought a house and then moved and afterwards Christmas :)

Anyway, can you make it so that it compiles when the audiodatacenter visualm libraries are not present.
Conditional compilation with #ifdef and so on.

- Ralf Engels


On Aug. 25, 2011, 9:23 a.m., Alessandro Siniscalchi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102277/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2011, 9:23 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> It add Amarok the visualization using projectM.
> 
> It uses the git of Phonon cause audioDataOutput is fixed in the gstreamer backend.
> 
> TODO: disconnection of audioDataPath make the audio path disconnect too... Phonon bug ?
> 
> 
> Diffs
> -----
> 
>   src/EngineController.h 3da2f239c64614491937e883ccb4a2d4ed29366d 
>   src/CMakeLists.txt e0cf2ba041cf42bc5c72d05fb08cf52afd789a04 
>   src/EngineController.cpp 5bea5c6e148de9cd440e479871c6f23497d7ad44 
>   src/MainWindow.h 076628f4b1c12d094b761867c600de2746d076bf 
>   src/MainWindow.cpp 2d2ebacce172fffaaf313294b690424e827b800b 
>   src/audiodatacenter/CMakeLists.txt PRE-CREATION 
>   src/audiodatacenter/audiodatacenter.h PRE-CREATION 
>   src/audiodatacenter/audiodatacenter.cpp PRE-CREATION 
>   src/audiodatacenter/audiodataclient.h PRE-CREATION 
>   src/audiodatacenter/audiodataclient.cpp PRE-CREATION 
>   src/visualm/CMakeLists.txt PRE-CREATION 
>   src/visualm/visualm.h PRE-CREATION 
>   src/visualm/visualm.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102277/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/102277/s/222/
> 
> 
> Thanks,
> 
> Alessandro Siniscalchi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120116/a5ee8d14/attachment.html>