Review Request: Line feed nedeed because the label makes window too wide

Ralf Engels ralf-engels at gmx.de
Sun Jan 15 23:03:20 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103298/#review9848
-----------------------------------------------------------

Ship it!


Harmless fix.
Will commit it if no-one vetoes it.

- Ralf Engels


On Nov. 30, 2011, 7:49 p.m., Pavel Punegov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103298/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2011, 7:49 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> In file /src/dynamic/biases/IfElseBias.cpp in 46th line the line feed needed because the string makes window too wide.
> In file /src/dynamic/biases/QuizPlayBias.cpp (118,122,126) some strings have unnecessary whitespaces after '\n' symbol. The second part (which after the '\n') of that stings are carried to next line and then begins with a whitespace character.
> 
> 
> Diffs
> -----
> 
>   src/dynamic/biases/IfElseBias.cpp f8888b9 
>   src/dynamic/biases/QuizPlayBias.cpp 4ffdf9e 
> 
> Diff: http://git.reviewboard.kde.org/r/103298/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Pavel Punegov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120115/c595a17f/attachment.html>


More information about the Amarok-devel mailing list