Review Request: Some changes to make Amarok appearance more pretty

Lucas Gomes x8lucas8x at gmail.com
Wed Jan 4 00:52:21 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103603/
-----------------------------------------------------------

(Updated Jan. 4, 2012, 12:52 a.m.)


Review request for Amarok and Bart Cerneels.


Changes
-------

Just ignore revision number 2. I don't know how to remove it :/.


Description
-------

This is my attempt to make QTreeView subclasses items, used in Amarok, more pretty by displaying some extra information. Notice that these extra information are usually the quantity of tracks in a album, the quantity of episodes in a podcast and the quantity of episodes marked as new in a podcast.

So, please help me to improve this feature even more by answering some questions:

1) Should I show the quantity of tracks on playlists listed in PlaylistBrowser too?
2) Is there any extra information that you think it's relevant to be showed somewhere (In QTreeViews)?

Link for my personal repository (Look for ui-improve branch):
http://quickgit.kde.org/index.php?p=clones%2Famarok%2Fgomes%2Fmaskmaster-amarok.git&a=summary


Diffs (updated)
-----

  src/browsers/CollectionTreeItemModelBase.cpp e7f8e62 
  src/browsers/playlistbrowser/PodcastModel.cpp 18334f6 

Diff: http://git.reviewboard.kde.org/r/103603/diff/diff


Testing
-------

This patch should build. Everything is working as expected and there aren't any known issues.


Screenshots
-----------

PodcastBrowser
  http://git.reviewboard.kde.org/r/103603/s/402/
CollectionBrowser
  http://git.reviewboard.kde.org/r/103603/s/401/


Thanks,

Lucas Gomes

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120104/1b5d37d4/attachment.html>


More information about the Amarok-devel mailing list