Review Request: Playing albums (adding delay)

[Myriam Schweingruber]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100837/#review10981
-----------------------------------------------------------


Any news on this? Please update the patch or remove it.

- Myriam Schweingruber


On March 10, 2011, 10 p.m., Nicholas Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100837/
> -----------------------------------------------------------
> 
> (Updated March 10, 2011, 10 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> When playing albums, I want add a delay between albums. Each album should ideally be played seamlessly, but jumping with not even a second's delay to a random album creates a very jarring effect. This is a preliminary patch to add a few seconds' pause in random album mode.
> 
> Questions:
> 1) UI. If this makes the cut, I guess there should be a config for it. The play modes menu is getting a bit cluttered, so perhaps it could be slightly re-engineered. I'll think about it if there is a chance of the feature being shipped.
> 2) Do we want this option to be available in normal album traversal? Adding a few seconds between albums, possibly with config, seems very sensible to me.
> 
> Also, the RandomAlbums mode needs some love. It currently ignores the favouring code which the UI suggests it should follow, and is less clever than the favoured track mode at avoiding playing the same thing again based on history. Would it be OK to fix that?
> 
> So, if I write it, will you take it, or is this feature not wanted?
> 
> 
> Diffs
> -----
> 
>   src/EngineController.h 4117a89 
>   src/EngineController.cpp ad85533 
>   src/playlist/navigators/RandomAlbumNavigator.cpp 6f0fe37 
> 
> Diff: http://git.reviewboard.kde.org/r/100837/diff/
> 
> 
> Testing
> -------
> 
> Tested on local files only. Using it already to improve random albums experience.
> 
> 
> Thanks,
> 
> Nicholas Wilson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120228/4fadd1fb/attachment.html>