Review Request: The patch makes the "add to playlist" action append the song to playlist instead of playing immediately.

[Bart Cerneels]

> On Feb. 25, 2012, 10:04 a.m., Myriam Schweingruber wrote:
> > I don't think the correction should be done in the PlaylistControler, the problem is in the PopupDropper only: amarok/src/context/popupdropper/libpud

I agree. This is not a proper bugfix, you just commented some code. If lines of code really are no longer needed you should delete them. But in this case you are probably breaking established functionality and wanted behavior.


- Bart


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104060/#review10886
-----------------------------------------------------------


On Feb. 24, 2012, 4:46 p.m., Parthasarathy Gopavarapu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104060/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2012, 4:46 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Patch for the Bug 194549 ( appending to playlist ).
> 
> I have changed it so as to append to the end of playlist instead of starting playing immediately.
> 
> 
> This addresses bug 194549.
>     https://bugs.kde.org/show_bug.cgi?id=194549
> 
> 
> Diffs
> -----
> 
>   src/playlist/PlaylistController.cpp e9de9fd 
> 
> Diff: http://git.reviewboard.kde.org/r/104060/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Parthasarathy Gopavarapu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120227/3d599420/attachment.html>