Review Request: The patch makes the "add to playlist" action append the song to playlist instead of playing immediately.

Myriam Schweingruber myriam at kde.org
Sat Feb 25 10:04:40 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104060/#review10886
-----------------------------------------------------------


I don't think the correction should be done in the PlaylistControler, the problem is in the PopupDropper only: amarok/src/context/popupdropper/libpud

- Myriam Schweingruber


On Feb. 24, 2012, 4:46 p.m., Parthasarathy Gopavarapu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104060/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2012, 4:46 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Patch for the Bug 194549 ( appending to playlist ).
> 
> I have changed it so as to append to the end of playlist instead of starting playing immediately.
> 
> 
> This addresses bug 194549.
>     https://bugs.kde.org/show_bug.cgi?id=194549
> 
> 
> Diffs
> -----
> 
>   src/playlist/PlaylistController.cpp e9de9fd 
> 
> Diff: http://git.reviewboard.kde.org/r/104060/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Parthasarathy Gopavarapu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120225/fec0465a/attachment.html>


More information about the Amarok-devel mailing list