Review Request: Preview of live scanning feature

[Bart Cerneels]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104049/#review10866
-----------------------------------------------------------



src/core-impl/collections/db/ScanManager.cpp
<http://git.reviewboard.kde.org/r/104049/#comment8805>

    With such complex nested code readability is even more important. Please change the style to comply with HACKING/intro_and_style.txt



src/core-impl/collections/db/ScanManager.cpp
<http://git.reviewboard.kde.org/r/104049/#comment8806>

    Commented out code should be removed.


- Bart Cerneels


On Feb. 23, 2012, 2:25 p.m., Ville Ranki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104049/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2012, 2:25 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> This is a preview of work i've been doing to implement live scanning. Currently it can do full scan 
> and add found tracks to database during the scan. Removing missing files is not yet implemented. Also partial 
> scan may not work as expected.
> 
> 
> Diffs
> -----
> 
>   src/core-impl/collections/db/ScanManager.h 5f0d153 
>   src/core-impl/collections/db/ScanManager.cpp 97d0b1c 
>   src/core-impl/collections/db/ScanResultProcessor.cpp 4f02a16 
>   src/core-impl/collections/db/sql/SqlScanResultProcessor.cpp 6699b98 
>   src/scanner/GenericScanManager.cpp 215f78b 
>   utilities/collectionscanner/CollectionScanner.h 6bbc757 
>   utilities/collectionscanner/CollectionScanner.cpp 74b57a6 
>   utilities/collectionscanner/Directory.cpp 66b3a9b 
> 
> Diff: http://git.reviewboard.kde.org/r/104049/diff/
> 
> 
> Testing
> -------
> 
> "Works on my pc" on a small test collection.
> 
> 
> Thanks,
> 
> Ville Ranki
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120224/4827fd3b/attachment.html>