Review Request: Change the playlist tooltip behaviour. Shows m_name instead of m_description.

Bart Cerneels bart.cerneels at kde.org
Thu Feb 23 15:47:52 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104048/#review10838
-----------------------------------------------------------


This can't be merged because it will break the database layout.


src/playlistmanager/sql/SqlPlaylist.cpp
<http://git.reviewboard.kde.org/r/104048/#comment8774>

    This breaks the database layout.
    You should have only removed it from the view.


- Bart Cerneels


On Feb. 23, 2012, 1:46 p.m., Claudio Desideri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104048/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2012, 1:46 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> My first attempt to contribute.
> 
> 
> This addresses bug 275821.
>     https://bugs.kde.org/show_bug.cgi?id=275821
> 
> 
> Diffs
> -----
> 
>   src/playlistmanager/sql/SqlPlaylist.h a001194 
>   src/playlistmanager/sql/SqlPlaylist.cpp 39ad759 
> 
> Diff: http://git.reviewboard.kde.org/r/104048/diff/
> 
> 
> Testing
> -------
> 
> It works. :P
> 
> 
> Thanks,
> 
> Claudio Desideri
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120223/6d135606/attachment.html>


More information about the Amarok-devel mailing list