Review Request: Extend the scope of the playground

Bart Cerneels bart.cerneels at kde.org
Fri Feb 17 08:22:57 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103999/#review10693
-----------------------------------------------------------


There is some very welcome cleanup in this patch.
I'm assuming this is to prepare for Equalizer features? Why don't we just move equalizer in the core?

- Bart Cerneels


On Feb. 17, 2012, 2:53 a.m., Ryan McCoskrie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103999/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2012, 2:53 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> This is infrastructure for future patches of mine. It's intended to (after some revising) make it relatively easy to develop code that is (mostly) in the playground directory but is (by necessity) compiled into the player binary.
> 
> Note: I'm only looking for criticism and have no intention of seeing this shipped.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt d47c28b 
>   playground/CMakeLists.txt e96aa3f 
>   playground/src/CMakeLists.txt ed740ec 
>   src/App.cpp 2f1837c 
>   src/CMakeLists.txt 4241e69 
> 
> Diff: http://git.reviewboard.kde.org/r/103999/diff/
> 
> 
> Testing
> -------
> 
> Checked that the code compiles.
> 
> 
> Thanks,
> 
> Ryan McCoskrie
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120217/886a0a79/attachment.html>


More information about the Amarok-devel mailing list