Review Request: Bug 173814 - JJ: add keyboard shortcut for "Edit Track Information..."

Jasneet Bhatti jazneetbhatti at gmail.com
Wed Feb 15 03:09:02 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103960/
-----------------------------------------------------------

(Updated Feb. 15, 2012, 3:09 a.m.)


Review request for Amarok.


Changes
-------

Removed the unnecessary ensurePolish() function.


Description
-------

This patch fixes the bug : https://bugs.kde.org/show_bug.cgi?id=173814

I've created a new slot that is called when the key combination is pressed. This slot in turn calls the concerned function to display Edit Track Details dialog.


Diffs (updated)
-----

  src/MainWindow.h 984aa28 
  src/MainWindow.cpp ea99659 
  src/playlist/PlaylistDock.h 897be1d 
  src/playlist/PlaylistDock.cpp b217e3c 

Diff: http://git.reviewboard.kde.org/r/103960/diff/


Testing
-------

I've tested this on ubuntu 11.10 with kubuntu-desktop and it seems to work fine.


Thanks,

Jasneet Bhatti

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120215/8b1fec98/attachment.html>


More information about the Amarok-devel mailing list