Review Request: Bug 173814 - JJ: add keyboard shortcut for "Edit Track Information..."

[Jasneet Bhatti]

> On Feb. 13, 2012, 8:40 a.m., Matěj Laitl wrote:
> > src/playlist/PlaylistDock.cpp, line 327
> > <http://git.reviewboard.kde.org/r/103960/diff/1/?file=49412#file49412line327>
> >
> >     Is there any specific reason this call is here?
> 
> Jasneet Bhatti wrote:
>     I was unable to completely understand it's role. It was apparently working fine without the call but I added it because it was there in all the other member function definitions, so I figured that it must be important.
> 
> Bart Cerneels wrote:
>     It's a hack. As far as I can tell it it not required in thus function, but you might want to test your shortcut at a moment when the view has not fully initialized yet (like during startup).

Ok, I'm uploading the patch without that function. And I've tested my shortcut in all ways that I could imagine. It works just as good as any other shortcut.


- Jasneet


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103960/#review10581
-----------------------------------------------------------


On Feb. 14, 2012, 5:05 a.m., Jasneet Bhatti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103960/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2012, 5:05 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> This patch fixes the bug : https://bugs.kde.org/show_bug.cgi?id=173814
> 
> I've created a new slot that is called when the key combination is pressed. This slot in turn calls the concerned function to display Edit Track Details dialog.
> 
> 
> Diffs
> -----
> 
>   src/MainWindow.h 984aa28 
>   src/MainWindow.cpp ea99659 
>   src/playlist/PlaylistDock.h 897be1d 
>   src/playlist/PlaylistDock.cpp b217e3c 
> 
> Diff: http://git.reviewboard.kde.org/r/103960/diff/
> 
> 
> Testing
> -------
> 
> I've tested this on ubuntu 11.10 with kubuntu-desktop and it seems to work fine.
> 
> 
> Thanks,
> 
> Jasneet Bhatti
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120215/5d4b80e8/attachment.html>