Review Request: Bug 261062 - JJ: Mark episodes to keep

[Lucas Gomes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100998/
-----------------------------------------------------------

(Updated Feb. 7, 2012, 8:57 p.m.)


Review request for Amarok.


Changes
-------

Moved keep status functionalities to SqlPodcastMeta and to SqlPodcastProvider,
since it's not something generic to be at their base class. Now "Keep downloaded file"
checkbox only appears if the file was already downloaded. Fixed a query, at
SqlPodcastChannel::loadEpisodes(), that wasn't producing results that are correctly
ordered by pubDate.


Description (updated)
-------

Now downloaded episodes are kept in HD, if "keep episode" checkbox is checked.
These "kept" episodes are shown in the list regardless of the purgecount.

BUG Description:

Currently downloaded files are not kept when the episode is no longer shown in
the Podcast section. This behavior can not be configured but is tied to the
purge settings of each channel.

It's possible to add a "keep downloaded file" checkbox to episodes to prevent
the deletion from happening. We should perhaps also show these "kept" episodes
in the list regardless of the purgecount. So even if a channel has purgecount 5
and 3 episodes marked to keep it will show 5 + maximum 3 older kept episodes.

Reproducible: Always


This addresses bug 261062.
    https://bugs.kde.org/show_bug.cgi?id=261062


Diffs (updated)
-----

  src/browsers/playlistbrowser/PodcastModel.cpp 18334f6 
  src/core-impl/podcasts/sql/SqlPodcastMeta.h 42ad039 
  src/core-impl/podcasts/sql/SqlPodcastMeta.cpp 1c3bdf4 
  src/core-impl/podcasts/sql/SqlPodcastProvider.h c3d5e56 
  src/core-impl/podcasts/sql/SqlPodcastProvider.cpp 183005f 
  src/core/podcasts/PodcastMeta.h 679f7ac 
  src/playlistmanager/SyncedPodcast.h c186df2 

Diff: http://git.reviewboard.kde.org/r/100998/diff/diff


Testing
-------


Thanks,

Lucas Gomes

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120207/7e749970/attachment.html>