Review Request: tag reading support for mod, s3m, it and xm files

[Mathias Stephan Panzenböck]

> On Feb. 2, 2012, 11:31 a.m., Matěj Laitl wrote:
> > shared/tag_helpers/TagHelper.cpp, line 358
> > <http://git.reviewboard.kde.org/r/101598/diff/3/?file=48464#file48464line358>
> >
> >     This change doesn't seem to be directly related to support for mod, s3m.. files. Could you provide rationale for it and the effects it has? It doesn't look bad, but I think it could break filetype-form-extension guessing in MetaTagLib.cpp:269-274. It would be great if you could test whether this is true or not.

Oh, I guess this slipped through. I'll remove it. I just added it to try what happens when I do that. But I didn't write a test case.


- Mathias Stephan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101598/#review10279
-----------------------------------------------------------


On Feb. 4, 2012, 4:32 p.m., Mathias Stephan Panzenböck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101598/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2012, 4:32 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> This patch adds read/write tag support for mod, s3m, it and xm files if taglib supports it. All new parts are #ifdefed so it won't break if an old taglib version is used.
> 
> I wrote a patch for taglib that enables support for these file formats and it will be included in taglib 1.8.0. Here is the pull request:
> https://github.com/taglib/taglib/pull/4
> 
> 
> This addresses bug 90524.
>     https://bugs.kde.org/show_bug.cgi?id=90524
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt d47c28b 
>   config-amarok.h.cmake 2d25cc7 
>   shared/FileType.h 5c8081f 
>   shared/FileType.cpp a6e25d5 
>   shared/FileTypeResolver.cpp e69a514 
>   shared/tag_helpers/TagHelper.cpp 4c0fb2b 
> 
> Diff: http://git.reviewboard.kde.org/r/101598/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mathias Stephan Panzenböck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120206/beaebab2/attachment.html>