Review Request: Change GUI strings in Configuration dialog to reduce user confusion

[Bart Cerneels]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103871/#review10369
-----------------------------------------------------------


Why do we even show these plugins at all? It's feels like a big implementation detail that should not be expose to the user to me.

- Bart Cerneels


On Feb. 5, 2012, 11:56 a.m., Matěj Laitl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103871/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2012, 11:56 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Change GUI strings in Configuration dialog to reduce user confusion
> 
> This is a result of a dialogue with an Amarok user (Leonidas Tsampros)
> on #amarok who (logically) thought that if he enables "NFS Device" in
> "Devices" section of Amarok plugins, NFS will pop-up as another
> collection.
> 
> This is not how SMB, NFS, MassStorage "Devices" work currently, they
> are meant to enable users to have a part of their collection on
> respective devices.
> 
> I believe that the old plugin names and descriptions are confusing to
> the extent that their translations should be dropped; it should be a
> plenty of time till Amarok 2.6 so translators should have opportunity
> to pickup these. (or, do .desktop translations get erased automatically
> when original string changes?)
> 
> CHANGES:
>  * "Devices" in Amarok configuration -> Plugins is with other related strings
>    renamed to "Local Collection Backends" to reduce user confusion.
> 
> BUG: 293277
> FIXED-IN: 2.6
> 
> 
> This addresses bug 293277.
>     https://bugs.kde.org/show_bug.cgi?id=293277
> 
> 
> Diffs
> -----
> 
>   ChangeLog ed4e955deeebf6a506e87ca8973645b9eeadc67b 
>   src/configdialog/ConfigDialog.cpp 1e8e30a7f02709fb8d02b705faf01de58f52ec94 
>   src/configdialog/dialogs/PluginsConfig.cpp 0e0ff1852ab192be2911cce3ed73dd42f38ab6f3 
>   src/core-impl/collections/db/sql/device/massstorage/amarok_device_massstorage.desktop 34dda8cda57e4ea8eb8980e5b6e3e44019718004 
>   src/core-impl/collections/db/sql/device/nfs/amarok_device_nfs.desktop 66a0b563c1e0daea8c77dd3fb6740c29897182de 
>   src/core-impl/collections/db/sql/device/smb/amarok_device_smb.desktop 82d5715971e6001d4b1a624f256b48ea121a8155 
> 
> Diff: http://git.reviewboard.kde.org/r/103871/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matěj Laitl
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120206/39267fbd/attachment-0001.html>