Review Request: Amarok: do not stop transfers when some files are already at destination

Dmitry Torokhov dmitry.torokhov at gmail.com
Fri Dec 21 21:21:59 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107841/
-----------------------------------------------------------

Review request for Amarok.


Description
-------

Amarok: do not stop transfers when some files are already at destination

This happens when you want to import a big tree of tracks at once and some
tracks are already present in the destination collection. In this case
TransferJob's copy subjob fails with KIO::ERR_FILE_ALEADY_EXIST and causes
entire transfer to complete prematurely.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov at gmail.com>


This addresses bug 312001.
    https://bugs.kde.org/show_bug.cgi?id=312001


Diffs
-----

  src/core-impl/collections/db/sql/SqlCollectionLocation.h c536f5626ea4ab24dc5afc0c24a779c61a004876 
  src/core-impl/collections/db/sql/SqlCollectionLocation.cpp 0b794db8d93e20634bf5271f16f3b63b5dffe97d 

Diff: http://git.reviewboard.kde.org/r/107841/diff/


Testing
-------


Thanks,

Dmitry Torokhov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20121221/a6ce9630/attachment.html>


More information about the Amarok-devel mailing list