Review Request: Layout changes to organize collection, guess metadata, edit filter and edit playlist layout dialogs

[Ralf Engels]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107624/
-----------------------------------------------------------

Review request for Amarok.


Description
-------

Several refactoring changes centering around token pool, token, token drop target and so on.

1. splitting up the FilenameLayoutDialog (which was not a dialog at all) into two widgets to be used by the actual dialog.
2. changing the token pool from an icon list to a normal list to prevent the use from having to scroll so much.
3. simplifying the drop target so that it does not need to install event filters for it's parents.
4. fixing small issues in the token pool, token and token drop target so that they have sensible minimumSizeHint and sizeHints
5. aligning texts between the different token users. No longer different texts.
6. for the edit filter dialog changes to the layout to get rid of the space waste in the result area.
7. for the guess tag dialog I got rid of some empty areas and some useless settings (settings that the dialog could determine itself)
8. for the playlist layout dialog not much has changed except that we don't need the event-filter parent mechanism.

Have a look at the attached screenshots to see the differences.
The actual code changes are in the rengels-filenameLayoutDialog branch.

Further work: Settings and presets need a reworking, as we have several sets currently which is confusing.


Diffs
-----

  ChangeLog 15a698c 

Diff: http://git.reviewboard.kde.org/r/107624/diff/


Testing
-------


Screenshots
-----------

Old Layout editor dialog
  http://git.reviewboard.kde.org/r/107624/s/878/
New Layout editor dialog
  http://git.reviewboard.kde.org/r/107624/s/879/
Old Guess Tag Dialog
  http://git.reviewboard.kde.org/r/107624/s/880/
New Guess Tag Dialog
  http://git.reviewboard.kde.org/r/107624/s/881/
Old Edit Filter Dialog
  http://git.reviewboard.kde.org/r/107624/s/882/
New Edit Filter Dialog
  http://git.reviewboard.kde.org/r/107624/s/883/


Thanks,

Ralf Engels

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20121207/65bd4c20/attachment.html>