Review Request: Fix: Recently played tracks are not updated in currrent track applet.

[Ralf Engels]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101015/#review18161
-----------------------------------------------------------


Spaces are good now as is the rest.

But I found some issues in conciseTime.



src/core/support/Amarok.h
<http://git.reviewboard.kde.org/r/101015/#comment14381>

    Even the old code was missing comments, like: /** Returns a translated string describing the time in words. The string will give more exact time than verboseTimeSince */



src/core/support/Amarok.cpp
<http://git.reviewboard.kde.org/r/101015/#comment14382>

    The date format needs to be translated too. Add a i18nc.



src/core/support/Amarok.cpp
<http://git.reviewboard.kde.org/r/101015/#comment14383>

    Here too, or use Qt::TimeSpec or something like this.



src/core/support/Amarok.cpp
<http://git.reviewboard.kde.org/r/101015/#comment14385>

    Using datetime.date().day() would be more performant. (No need to allocate and fill a QString)



src/core/support/Amarok.cpp
<http://git.reviewboard.kde.org/r/101015/#comment14384>

    Again i18n. The tricky thing with "hh:mm" is that not all countries use a leading zero for the hour. At least Qt is already handling 12/24 hour.
    
    To circumvent the problem use Qt::TimeSpec again.


Here is a nice Wiki page: http://en.wikipedia.org/wiki/Category:Date_and_time_representation_by_country

- Ralf Engels


On Aug. 26, 2012, 5:28 p.m., Conrad Hübler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101015/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2012, 5:28 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> The recentlyplayedtracks-widget from the current track applet does not update the last played time of recently played tracks. It now happens, every 60000 msec and after amarok stops.
> 
> It is just a hack for the next release making this applet working as it should, but it is not a proper solution for this problem.
> 
> 
> Diffs
> -----
> 
>   src/core/support/Amarok.h d8c91e7 
>   src/core/support/Amarok.cpp 7541124 
>   src/context/applets/currenttrack/CurrentTrack.h e023e91 
>   src/context/applets/currenttrack/CurrentTrack.cpp aa83a66 
>   src/context/applets/currenttrack/currentTrackSettings.ui c006384 
>   src/context/widgets/RecentlyPlayedListWidget.h 37032cb 
>   src/context/widgets/RecentlyPlayedListWidget.cpp 3b7bd72 
> 
> Diff: http://git.reviewboard.kde.org/r/101015/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Conrad Hübler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120828/76682465/attachment.html>