Review Request: Extend the scope of the playground

Ryan McCoskrie ryan.mccoskrie at gmail.com
Sun Aug 19 22:09:18 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103999/
-----------------------------------------------------------

(Updated Aug. 19, 2012, 10:09 p.m.)


Review request for Amarok.


Description (updated)
-------

This is infrastructure for future patches of mine (specifically equalizer scripting now that I am back on it).
The intention of this patch is to allow for the /playground directory to compile code directly into the
Amarok binary. The benefit this has to the Amarok project is that stable releases can include some experimental
featues that power users can opt into using.

Changes made to this patch:
0 Separated from a minor clean up of the playground
0 Separated from my equalizer scripting code (How on Earth did I overlook that?)
0 Added a brief tutorial on compiling in playground code
0 Now address all platforms, not just those using X11
0 Now intended for serious consideration of shipping.


Diffs (updated)
-----

  CMakeLists.txt ebb8064 
  playground/PLAYER_BINARY.txt PRE-CREATION 
  playground/src/CMakeLists.txt ed740ec 
  src/CMakeLists.txt 8596144 

Diff: http://git.reviewboard.kde.org/r/103999/diff/


Testing (updated)
-------

Checked that the code compiles with the playground option enabled.
Since there is no active code, this should be sufficiant.


Thanks,

Ryan McCoskrie

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120819/e748d0f9/attachment-0001.html>


More information about the Amarok-devel mailing list