Review Request: Remove obsolete dependancies from playground
Matěj Laitl
matej at laitl.cz
Sun Aug 19 08:56:21 UTC 2012
> On Aug. 18, 2012, 10:17 a.m., Matěj Laitl wrote:
> > Ship it! Just to be sure, your testing "the code compiles" was with ENABLE_PLAYGROUND enabled, right? Do you heve developer status on identity.k.o to commit yourself?
>
> Ryan McCoskrie wrote:
> Yes I did compile it with ENABLE_PLAYGROUND, this patch is actually just my old extended playground patch with the insertions removed. No I don't have developer status and until I get used to team work that a _very_ good thing,
Hmm, I'm curious for you to finish your sentence..
- Matěj
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106067/#review17649
-----------------------------------------------------------
On Aug. 18, 2012, 1:26 a.m., Ryan McCoskrie wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106067/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2012, 1:26 a.m.)
>
>
> Review request for Amarok.
>
>
> Description
> -------
>
> Removed several dependancies from /playground/CMakeLists.txt that /CMakeLists.txt and /src/CMakeLists.txt handle better.
>
>
> Diffs
> -----
>
> playground/CMakeLists.txt e96aa3f
>
> Diff: http://git.reviewboard.kde.org/r/106067/diff/
>
>
> Testing
> -------
>
> Checked that it compiles. No discrernable differences.
>
>
> Thanks,
>
> Ryan McCoskrie
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120819/bee22556/attachment.html>
More information about the Amarok-devel
mailing list