Review Request: GSoC report: Integrate Spotify into Amarok #3 (squashed commits, recent on top)

[Bart Cerneels]

> On Aug. 17, 2012, 12:22 p.m., Ralf Engels wrote:
> > I can only see the changed copyright header.
> > Is this request still valid? Can we reject it?

Ryan should probably close this one, rebase his gsoc branch and upload a new, full diff to a new review board. Want feedback from more people since it's GSoC evaluation time anyway.


- Bart


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105201/#review17592
-----------------------------------------------------------


On June 11, 2012, 1:26 p.m., Zhengliang Feng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105201/
> -----------------------------------------------------------
> 
> (Updated June 11, 2012, 1:26 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Add Spotify collection code
> 
> Currently implemented SpotifyCollection, SpotifyQueryMaker and
> SpotifyMeta. The ScriptResolver is the class handles communcation with
> standalone Spotify resolver, the code is mainly from original
> ScriptResolver, but added more functions to handle messages separately.
> 
> The controller class is used to start a ScriptResolver in a separate
> thread and handles queries.
> 
> 
> Diffs
> -----
> 
>   src/core-impl/collections/spotifycollection/support/ScriptResolver.h PRE-CREATION 
>   src/core-impl/collections/spotifycollection/support/ScriptResolver.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/105201/diff/
> 
> 
> Testing
> -------
> 
> Communication between ScriptResolver and Spotify resolver( from Tomahawk resolver repo https://github.com/ofan/tomahawk-resolvers ).
> Logging into Spotify using a username and password.
> 
> 
> Thanks,
> 
> Zhengliang Feng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120817/e704ebbe/attachment-0001.html>