Review Request: Support for equalizer scripts and plugins. WIP.

[Ryan McCoskrie]

> On Aug. 16, 2012, 10:18 a.m., Ralf Engels wrote:
> > Is this still WIP?

Well it's been a work in progress in the same sense that I'm learning to play the harmonica that has been sitting idly on my desk for a month or two. Now that I'm getting emails about it however I'll start afresh.


- Ryan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102798/#review17511
-----------------------------------------------------------


On Nov. 18, 2011, 11:47 p.m., Ryan McCoskrie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102798/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2011, 11:47 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> This patch is the beginning of an effort to make a generic equalizer interface for plugins and scripts to access.
> 
> 0: Gives the EngineController controller class new functions for examining, choosing and altering presets.
> 0: AmarokEngineScript provides functions to access the simpler equalizer functions in EngineController.
> 0: EqualizerDialog now uses the The::engineController() as a back end.
> 
> WARNING: I don't properly understand how the equalizer works. The largest changes in this patch are mostly
> code moved from EqualizerDialog to EngineController. It's quite ugly in places.
> 
> 
> Diffs
> -----
> 
>   src/ActionClasses.cpp 5d87f4b 
>   src/EngineController.h 3da2f23 
>   src/EngineController.cpp 6060137 
>   src/dialogs/EqualizerDialog.h 9dad055 
>   src/dialogs/EqualizerDialog.cpp ddcd300 
>   src/scriptengine/AmarokEngineScript.h f1cdb8c 
>   src/scriptengine/AmarokEngineScript.cpp 395c504 
> 
> Diff: http://git.reviewboard.kde.org/r/102798/diff/
> 
> 
> Testing
> -------
> 
> 0: Briefly tested the Amarok.Engine.eqChangeCurrentPreset() function in the script console. Works as expected.
> 0: Amarok.Engine.eqBandsFreq() seems to return no value.
> 
> ####################
> #  First Revision  #
> ####################
> 0: Opened script console and Equalizer Dialog. Used both the dialog and Amarok.Engine.currentPreset property
> to alter the equalizer. Everything appears to work properly.
> 
> 
> Thanks,
> 
> Ryan McCoskrie
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120817/edd72176/attachment-0001.html>