Review Request: GSoC report: Integrate Spotify into Amarok #4 (squashed commits, recent on top)

[Zhengliang Feng]

> On Aug. 13, 2012, 4:43 p.m., Edward Hades Toroshchin wrote:
> >

Actually these are from PlaydarCollection, I will reformat all signal & slot names later.


> On Aug. 13, 2012, 4:43 p.m., Edward Hades Toroshchin wrote:
> > src/core-impl/collections/spotifycollection/support/Controller.cpp, line 266
> > <http://git.reviewboard.kde.org/r/105285/diff/3/?file=77325#file77325line266>
> >
> >     I haven't found the place where query is deleted.

The controller has a query cache, all query pointers are managed by KSharedPtr, a query emits queryDone() after finished or timed out, then the controller clear the reference count and removes the pointer from the cache, the query should be deleted then.  I will add some test to double check this.


> On Aug. 13, 2012, 4:43 p.m., Edward Hades Toroshchin wrote:
> > src/core-impl/collections/spotifycollection/support/Controller.cpp, lines 462-486
> > <http://git.reviewboard.kde.org/r/105285/diff/3/?file=77325#file77325line462>
> >
> >     Is this _really_ needed? Can spotify resolver be sometimes ".exe" and sometimes python script or ".doc"? :)

Oh, this is because I borrowed ScriptResolver from Tomahawk, it supports scripts, I've removed this code. Thanks for pointing it out. :)


- Zhengliang


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105285/#review17322
-----------------------------------------------------------


On Aug. 13, 2012, 11:24 a.m., Zhengliang Feng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105285/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2012, 11:24 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Things I've done this week:
> * Added a new playlist provider SpotifyPlaylistProvider
> * Added playlist class SpotifyPlaylist
> * Clear all extra whitespaces
> * Figured out how Collection, QueryMaker and Playlist worked
> 
> Things need to be done next week:
> * Clean ScriptResolver's interfaces, move all query related interfaces into Query class
> * Replace Controller class with ScriptResolver
> * Test SpotifyCollection
> * Finish playlist and playlist provider
> 
> 
> Diffs
> -----
> 
>   src/core-impl/collections/CMakeLists.txt c78b920 
>   src/core-impl/collections/spotifycollection/CMakeLists.txt PRE-CREATION 
>   src/core-impl/collections/spotifycollection/SpotifyCollection.h PRE-CREATION 
>   src/core-impl/collections/spotifycollection/SpotifyCollection.cpp PRE-CREATION 
>   src/core-impl/collections/spotifycollection/SpotifyConfig.h PRE-CREATION 
>   src/core-impl/collections/spotifycollection/SpotifyConfig.cpp PRE-CREATION 
>   src/core-impl/collections/spotifycollection/SpotifyConfigWidget.ui PRE-CREATION 
>   src/core-impl/collections/spotifycollection/SpotifyMeta.h PRE-CREATION 
>   src/core-impl/collections/spotifycollection/SpotifyMeta.cpp PRE-CREATION 
>   src/core-impl/collections/spotifycollection/SpotifyPlaylist.h PRE-CREATION 
>   src/core-impl/collections/spotifycollection/SpotifyPlaylist.cpp PRE-CREATION 
>   src/core-impl/collections/spotifycollection/SpotifyPlaylistProvider.h PRE-CREATION 
>   src/core-impl/collections/spotifycollection/SpotifyPlaylistProvider.cpp PRE-CREATION 
>   src/core-impl/collections/spotifycollection/SpotifyQueryMaker.h PRE-CREATION 
>   src/core-impl/collections/spotifycollection/SpotifyQueryMaker.cpp PRE-CREATION 
>   src/core-impl/collections/spotifycollection/SpotifySettings.h PRE-CREATION 
>   src/core-impl/collections/spotifycollection/SpotifySettings.cpp PRE-CREATION 
>   src/core-impl/collections/spotifycollection/amarok_collection-spotifycollection.desktop PRE-CREATION 
>   src/core-impl/collections/spotifycollection/support/Controller.h PRE-CREATION 
>   src/core-impl/collections/spotifycollection/support/Controller.cpp PRE-CREATION 
>   src/core-impl/collections/spotifycollection/support/QMFunctionTypes.h PRE-CREATION 
>   src/core-impl/collections/spotifycollection/support/Query.h PRE-CREATION 
>   src/core-impl/collections/spotifycollection/support/Query.cpp PRE-CREATION 
>   src/core-impl/collections/spotifycollection/support/TrackProxy.h PRE-CREATION 
>   src/core-impl/collections/spotifycollection/support/TrackProxy.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/105285/diff/
> 
> 
> Testing
> -------
> 
> No test done this week. 
> 
> 
> Thanks,
> 
> Zhengliang Feng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120815/a4639941/attachment-0001.html>