Review Request: Removes unnecessary OpenGL constraints from the spectrum analyzer

[Matěj Laitl]

> On Aug. 9, 2012, 6:52 a.m., David Smith wrote:
> > Ship It!

Hi David, it is usual that only estabilished Amarok developers give "Ship it!" on review requests. All users are of course encouraged to test review requests and report their findings.


- Matěj


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104330/#review17135
-----------------------------------------------------------


On March 18, 2012, 1:46 p.m., Daniel Dewald wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104330/
> -----------------------------------------------------------
> 
> (Updated March 18, 2012, 1:46 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Removes some unnecessary OpenGL constraints from the spectrum analyzer (See Bug# 290327). Also extended the remaining constraints error messages to clarify that its an OpenGL problem.
> 
> 
> This addresses bug 290327.
>     https://bugs.kde.org/show_bug.cgi?id=290327
> 
> 
> Diffs
> -----
> 
>   src/context/applets/spectrumanalyzer/SpectrumAnalyzerApplet.cpp 8d5ad25 
> 
> Diff: http://git.reviewboard.kde.org/r/104330/diff/
> 
> 
> Testing
> -------
> 
> Since my graphic card supports all the removed constraints I can't really test if the problem is gone now. Someone with an older card should test if the error message is gone now.
> 
> 
> Thanks,
> 
> Daniel Dewald
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120809/61771af1/attachment.html>