Review Request: Allow guessing of tags from filenames for multiple files

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105875/#review17058
-----------------------------------------------------------


Thanks for the patch, let me review it once Amarok 2.6 is released and I have a bit more of free time.

- Matěj Laitl


On Aug. 6, 2012, 10:14 a.m., Matthias Berndt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105875/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2012, 10:14 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Allow guessing of tags from filenames for multiple files
> (bug #213074).
> 
> Refactor some of the code in order to reuse some of the code intended
> for MusicBrainz
> 
> make the tag guessing dialog non-modal
> 
> 
> This addresses bug 213074.
>     https://bugs.kde.org/show_bug.cgi?id=213074
> 
> 
> Diffs
> -----
> 
>   shared/TagsFromFileNameGuesser.cpp f2ec2ba 
>   src/core/meta/support/MetaConstants.h 41c78a9 
>   src/core/meta/support/MetaConstants.cpp 079fd22 
>   src/dialogs/FilenameLayoutDialog.cpp 1517a8a 
>   src/dialogs/TagDialog.h 015f2d3 
>   src/dialogs/TagDialog.cpp a448458 
>   src/dialogs/TagGuesser.h 432d38f 
>   src/dialogs/TagGuesser.cpp b1a503f 
> 
> Diff: http://git.reviewboard.kde.org/r/105875/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matthias Berndt
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120807/0e0e6364/attachment.html>