Review Request: Fixed Bug 272346, unable to set MySQL password to 'password'

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104751/#review13052
-----------------------------------------------------------


This review has been submitted with commit b7fb7034757e185ceb0a17180314dd7b63fb4169 by Lachlan Dufton to branch master.

- Commit Hook


On April 26, 2012, 11 p.m., Lachlan Dufton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104751/
> -----------------------------------------------------------
> 
> (Updated April 26, 2012, 11 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Fix for bug #272346. If the user set the MySQL password to "password" it would be interpreted as no password due to a mismatch in default config values.
> 
> 
> This addresses bug 272346.
>     https://bugs.kde.org/show_bug.cgi?id=272346
> 
> 
> Diffs
> -----
> 
>   src/core-impl/collections/db/sql/mysqlservercollection/MySqlServerCollection.cpp 7ae8bdf 
> 
> Diff: http://git.reviewboard.kde.org/r/104751/diff/
> 
> 
> Testing
> -------
> 
> Tested connecting to an external database with passwords set to: "", "password", "other" and verified the correct connection was made in each case.
> 
> 
> Thanks,
> 
> Lachlan Dufton
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120429/c12f8b50/attachment-0001.html>