Review Request: Proof of Concepts implementation for the Amarok Current Track Model

[Bart Cerneels]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104598/#review12498
-----------------------------------------------------------


I don't think a QItemModel is appropriate for the currently playing track info. After all, there only is one current track at a time. Using a model is really for lists of data.
You could have used a QObject with the appropriate properties (name, artist, etc.) which is a lot less overhead both in C++ and QML.


src/CMakeLists.txt
<http://git.reviewboard.kde.org/r/104598/#comment9807>

    The filename is a bit undescriptive just as the class-name. Should be full: CurrentTrackModel and be put in a namespace.


- Bart Cerneels


On April 14, 2012, 7:15 p.m., Saurabh Sood wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104598/
> -----------------------------------------------------------
> 
> (Updated April 14, 2012, 7:15 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> This is my Proof of Concepts Implementation of the CurrentTrack data model. I have implemented the data model using QAbstractItemModel, and exposed the data to a QML view using QDeclarative module. I have covered only the Artist Name, and the Track name as of now, but this can be changed when I do the actual implementation. I have implemented the QML view using a QWidget at present, which is shown independently.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 43bda903e4b1d2ef9bedff0f829ef2eed56e891f 
>   src/CTrack.h PRE-CREATION 
>   src/CTrack.cpp PRE-CREATION 
>   src/MainWindow.h d49776476ce8b23013c1a8880a640d9aef35e817 
>   src/MainWindow.cpp 76f5cebc1cdb4fa2b93784c4500b55333b7ea66d 
>   src/current.qml PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/104598/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Amarok QML View
>   http://git.reviewboard.kde.org/r/104598/s/528/
> 
> 
> Thanks,
> 
> Saurabh Sood
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120416/5336a2cf/attachment.html>