Review Request: tag reading support for mod, s3m, it and xm files

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101598/#review12417
-----------------------------------------------------------


Thanks for maintaining this. Any news on when TagLib 1.8 is going to be released?

- Matěj Laitl


On April 13, 2012, 8:38 p.m., Mathias Stephan Panzenböck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101598/
> -----------------------------------------------------------
> 
> (Updated April 13, 2012, 8:38 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> This patch adds read/write tag support for mod, s3m, it and xm files if taglib supports it. All new parts are #ifdefed so it won't break if an old taglib version is used.
> 
> I wrote a patch for taglib that enables support for these file formats and it will be included in taglib 1.8.0. Here is the pull request:
> https://github.com/taglib/taglib/pull/4
> 
> 
> This addresses bug 90524.
>     https://bugs.kde.org/show_bug.cgi?id=90524
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt d47c28b 
>   ChangeLog 3360459 
>   config-amarok.h.cmake 2d25cc7 
>   shared/FileType.h ba31e92 
>   shared/FileType.cpp 3ec66de 
>   shared/FileTypeResolver.cpp e69a514 
>   shared/tag_helpers/TagHelper.cpp 3365432 
> 
> Diff: http://git.reviewboard.kde.org/r/101598/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mathias Stephan Panzenböck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120414/5d10590c/attachment.html>