Review Request: KWallet for Magnatune credentials

[Andrzej Hunt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104480/
-----------------------------------------------------------

Review request for Amarok.


Description
-------

Modifies the Magnatune service to use KWallet for storage (instead of plaintext).

The code has been copied from LastFmServiceConfig.cpp, with almost no modification on my part. (KDevelop removed some whitespace and reformatted some other bits of code meaning there are some formatting changes in the diff -- I apologise if this is a problem for reviewing, and I can revert the formatting changes if desired.)

A question about copyright attribution:  Would this be the correct thing to add to MagnatuneConfig.cpp below the current copyright line?

 * Code copied from ../lastfm/LastFmServiceConfig.cpp:
 * Copyright (c) 2007 Shane King <kde at dontletsstart.com>                                
 * Copyright (c) 2009 Leo Franchi <lfranchi at kde.org> 


This addresses bug 242256.
    https://bugs.kde.org/show_bug.cgi?id=242256


Diffs
-----

  src/services/magnatune/MagnatuneConfig.cpp 18ee898 
  src/services/magnatune/MagnatuneConfig.h f1d25eb 

Diff: http://git.reviewboard.kde.org/r/104480/diff/


Testing
-------


Thanks,

Andrzej Hunt

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120403/113652b4/attachment.html>