Review Request: Diagnostics Dialog for Amarok.

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104449/#review12109
-----------------------------------------------------------

Ship it!


As Bart said, very good patch, thanks for it! Besides to what Bart already pointed out, I've found 2 minor things.


src/MainWindow.h
<http://git.reviewboard.kde.org/r/104449/#comment9536>

    Nitpicking: perhaps unnecessary newline



src/dialogs/DiagnosticDialog.h
<http://git.reviewboard.kde.org/r/104449/#comment9537>

    Any special reason why the QWeakPointer is used? If there is none, plain pointer should be used instead.


- Matěj Laitl


On March 31, 2012, 6:15 p.m., Andrzej Hunt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104449/
> -----------------------------------------------------------
> 
> (Updated March 31, 2012, 6:15 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Adds a diagnostics dialog to Amarok. This shows versions for KDE, QT, Phonon, the Phonon backend, and all scripts and plugins.
> 
> As described in https://bugs.kde.org/show_bug.cgi?id=296415.
> 
> This patch also changes/corrects PluginManager::plugins() to be const.
> 
> 
> This addresses bug 296415.
>     https://bugs.kde.org/show_bug.cgi?id=296415
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 6e590e8 
>   src/MainWindow.h b149cb9 
>   src/MainWindow.cpp 98b1c77 
>   src/PluginManager.h 6b9f3ca 
>   src/PluginManager.cpp c46b12f 
>   src/dialogs/DiagnosticDialog.h PRE-CREATION 
>   src/dialogs/DiagnosticDialog.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/104449/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Screenshot of Dialog
>   http://git.reviewboard.kde.org/r/104449/s/501/
> 
> 
> Thanks,
> 
> Andrzej Hunt
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120402/b0bfa1d2/attachment-0001.html>