Review Request: Amazon store WIP patch

[Sven Krohlas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102596/
-----------------------------------------------------------

(Updated Sept. 13, 2011, 4:36 p.m.)


Review request for Amarok.


Changes
-------

* pushed changes to Magnatune and SearchWidget to master
* simplified album and track creation in the parser (thanks to some changes in the api xml). more changes to come.
* added link to API documentation
* make the collection not show up in the local collection

Items do sill not show up in the browser.


Summary
-------

Totally WIP! Many, many TODOs and unfinished stuff in the code... pls ignore. ;-)

I'm currently stuck at the point that my parser created meta items do not show up in the browser... any idea why?


Diffs (updated)
-----

  src/browsers/CollectionTreeItemModelBase.cpp 119f90d 
  src/core-impl/collections/support/MemoryQueryMakerInternal.h d3825ca 
  src/core/collections/Collection.h 02b0894 
  src/core/collections/QueryMaker.h dfca79f 
  src/services/CMakeLists.txt ad14fda 
  src/services/ServiceCollection.h 7a57aa6 
  src/services/ServiceMetaBase.cpp 21587d3 
  src/services/amazon/Amazon.h PRE-CREATION 
  src/services/amazon/AmazonActions.h PRE-CREATION 
  src/services/amazon/AmazonActions.cpp PRE-CREATION 
  src/services/amazon/AmazonCart.h PRE-CREATION 
  src/services/amazon/AmazonCart.cpp PRE-CREATION 
  src/services/amazon/AmazonCollection.h PRE-CREATION 
  src/services/amazon/AmazonCollection.cpp PRE-CREATION 
  src/services/amazon/AmazonConfig.h PRE-CREATION 
  src/services/amazon/AmazonConfig.cpp PRE-CREATION 
  src/services/amazon/AmazonConfigWidget.ui PRE-CREATION 
  src/services/amazon/AmazonMeta.h PRE-CREATION 
  src/services/amazon/AmazonMeta.cpp PRE-CREATION 
  src/services/amazon/AmazonParser.h PRE-CREATION 
  src/services/amazon/AmazonParser.cpp PRE-CREATION 
  src/services/amazon/AmazonSettingsModule.h PRE-CREATION 
  src/services/amazon/AmazonSettingsModule.cpp PRE-CREATION 
  src/services/amazon/AmazonStore.h PRE-CREATION 
  src/services/amazon/AmazonStore.cpp PRE-CREATION 
  src/services/amazon/CMakeLists.txt PRE-CREATION 
  src/services/amazon/amarok_service_amazonstore_config.desktop PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/102596/diff


Testing
-------


Screenshots
-----------

Unknown entry/entries after parsing
  http://git.reviewboard.kde.org/r/102596/s/256/


Thanks,

Sven

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20110913/1ce0cf66/attachment.html>